Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ExtendedLiterals extension #8992

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Add the ExtendedLiterals extension #8992

merged 1 commit into from
Jun 10, 2023

Conversation

monoidal
Copy link
Member

@monoidal monoidal commented Jun 1, 2023 •
edited
Loading

GHC 9.8 will feature a new extension, ExtendedLiterals: ghc/ghc@931c8d8.

I am adding it to Cabal following Note [Adding a language extension] in GHC.

A comment says that I should update languageExtensions which I believe is now compilerExtensions. As far as I can tell there's nothing to change, since supported GHC flags are fetched rather than hardcoded.

Please include the following checklist in your PR:

Bonus points for added automated tests!

@monoidal monoidal force-pushed the wip/extended-literals branch 2 times, most recently from eb6d263 to 1fbcdb2 Compare June 6, 2023 12:57
@andreabedini andreabedini self-requested a review June 7, 2023 03:33
andreabedini
andreabedini approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ulysses4ever
ulysses4ever approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Good to know that GHC has a note. We usually suggest to look at a previous commit touching the extensions. You may find a couple more things there. Notes can go out of date, as you found...

@monoidal monoidal force-pushed the wip/extended-literals branch 2 times, most recently from 6e9dbd2 to 888d7d8 Compare June 7, 2023 12:41
@monoidal
Copy link
Member Author

monoidal commented Jun 7, 2023

I've looked at the last two changes: 49b91e0 and f13a189. There was a changelog entry in the latter so I've copy-pasted it here.

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 7, 2023 •
edited
Loading

Thank you! Changelogs are important because they form release notes.

@ulysses4ever
Copy link
Collaborator

@andreabedini your approval somehow doesn't get counted? In the list of checks i only see my approval...

@andreabedini
Copy link
Collaborator

@andreabedini your approval somehow doesn't get counted? In the list of checks i only see my approval...

🤷 not sure ☺️

@ulysses4ever
Copy link
Collaborator

@andreabedini I bumped your access level, and now your vote counts. Thanks!

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jun 7, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 9, 2023
@andreabedini
Copy link
Collaborator

Unable to update: user monoidal is unknown.
Please make sure monoidal has logged in Mergify dashboard.

WUT? How is this a requirement?

@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2023

rebase

✅ Branch has been successfully rebased

@ulysses4ever
Copy link
Collaborator

@andreabedini this is an unfortunate recent change in the bot to force people into a paid tire I believe: if the target branch went ahead, only PRs from admins get rebased, otherwise an admin need to explicitly ask the bot to rebase.

@mergify mergify bot merged commit 14a0103 into haskell:master Jun 10, 2023
Kleidukos added a commit that referenced this pull request Aug 20, 2023
@Kleidukos
Add the ExtendedLiterals extension (backport of #8992)
9faa4db
Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Sep 14, 2023
@Kleidukos
Revert "Add the ExtendedLiterals extension (backport of haskell#8992)"
cb7568b 
This reverts commit 9faa4db.
Kleidukos added a commit that referenced this pull request Sep 20, 2023
@Kleidukos
Revert "Add the ExtendedLiterals extension (backport of #8992)" (#9260)
4712f85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreabedini andreabedini andreabedini approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monoidal @ulysses4ever @andreabedini