root relative glob expansion of extra source files #8640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Looks plausible! I wonder if we need to audit other uses of this function. For example, it looks like in Install.hs there is some matching of data files that falls back to resolving from . if the data dir isn't set. Or perhaps rather the thing that's questionable there (and generally in a multi-package world) is the use of . 🤔
andreasabel
approved these changes
Jan 2, 2023
|
no regression tests lately 😟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8632
Resolves #8634
This was indeed a bug in #7608
The confusion is that the cabal in the 3.6 series tested against did not contain a backport of that patch.
The issue is that extra-source-file glob expansion was written to expand relative to "." rather than the relative root of the package in question. So this worked in single-package setups, but not when in the base directory of a project with multiple packages.
Along the way, this bumps the verbosity of glob expansion.