Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove piece of incomplete documentation #8459

Closed
wants to merge 1 commit into from

Conversation

andreabedini
Copy link
Collaborator

Virtual modules are discussed right below in the library section.


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@andreabedini
Copy link
Collaborator Author

I need to check if this is library pkg field or not.

@andreabedini andreabedini marked this pull request as draft September 8, 2022 14:59
@BinderDavid
Copy link
Contributor

BinderDavid commented Oct 21, 2023

Is anything preventing this from being merged? This TODO still exists in the docs, and the field is already documented in the package description section. I don't want to open another PR if this one is already open.

@ulysses4ever
Copy link
Collaborator

@andreabedini do you want to connect this to the Ready state (it's currently Draft)? Also, there's a docs build failure?

@ulysses4ever
Copy link
Collaborator

@mergify rebase

Virtual modules are discussed right below in the library section.
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2023

rebase

✅ Branch has been successfully rebased

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Oct 22, 2023

Looks like this part of the output is related:

/home/runner/work/cabal/cabal/doc/buildinfo-fields-reference.rst:507: WARNING: cabal:pkg-field reference target not found: virtual-modules

@BinderDavid
Copy link
Contributor

The section was removed in #9400

@BinderDavid BinderDavid closed this Nov 8, 2023
@andreabedini andreabedini deleted the andreabedini-patch-2 branch November 8, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants