Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency on process #8279

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Bump dependency on process #8279

merged 1 commit into from
Jul 11, 2022

Conversation

robx
Copy link
Collaborator

@robx robx commented Jul 9, 2022

Compare the discussion in #8208.

@robx
Copy link
Collaborator Author

robx commented Jul 9, 2022

It turns out that process-1.6.14.0 depends on base-4.10 (so GHC 8.2). (That lower bound came with this PR and is probably not due to incompatibility, but just because CI doesn't test GHC versions earlier than 8.2.)

@Mikolaj
Copy link
Member

Mikolaj commented Jul 9, 2022

I think we are going to need another RC, in which case there's going to be enough time to dogfood (and userfood) this change.

@robx robx marked this pull request as ready for review July 9, 2022 15:40
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's brave so late in the release process, but seems unavoidable.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks, let's see what is the behaviour in Windows (not sure when I will have time to give a try)

@@ -9,6 +9,15 @@
"source": "local",
"version": "3.9.0.0"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow some way to generate this auto would be handy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is auto-generated with make update-bootstrap-jsons or something like that. But, if we are lukcy, a backport is going to be easier with the small change.

@robx robx added the merge me Tell Mergify Bot to merge label Jul 11, 2022
This is guarded to be for GHC from 8.2 only, since the process release
depends on base-4.10.

Includes an update to the bootstrapping files.
@mergify mergify bot merged commit 12651e4 into haskell:master Jul 11, 2022
@Mikolaj
Copy link
Member

Mikolaj commented Jul 11, 2022

@Mergifyio backport 3.8

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2022

backport 3.8

✅ Backports have been created

@robx robx deleted the bump-process branch July 11, 2022 23:48
mergify bot added a commit that referenced this pull request Jul 12, 2022
@Mikolaj
Copy link
Member

Mikolaj commented Jul 12, 2022

I've just tried cabal from https://gitlab.haskell.org/haskell/cabal/-/jobs/1108769 and I no longer see the spurious process messages. Was worth it. :)

@Mikolaj
Copy link
Member

Mikolaj commented Aug 4, 2022

It seems we need to bump up the process package one notch again due to NorfairKing/feedback#2

I think it's not grave enough to derail 3.8.1.0, but let's backport for the benefit of the hypothetical 3.8.2.0.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 4, 2022

It seems we need to bump up the process package one notch again due to NorfairKing/feedback#2

Let me do that in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants