Skip to content

CONTRIBUTING: Describe project and milestone usage #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 10, 2022


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

CONTRIBUTING.md Outdated
GitHub conventions
-------------------

Each `Cabal`/`cabal-install` release has a corresponding GitHub Project and milestone.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Each major"? 3.6.3 doesn't have a project. 3.6 does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 3.6.3 a minor release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant new 3.x numbers, because that seems to be what we really plan for, while 3.x.y are reactive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*major are 3.x numbers

CONTRIBUTING.md Outdated

Each `Cabal`/`cabal-install` release has a corresponding GitHub Project and milestone.
A ticket is included in a release's project if the release manager is tenatively
planning on including a fix for the ticket in the release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(add -- i.e. if they are actively seeking someone to work on the ticket)

Copy link
Member

@jneira jneira Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the release manager can do it, then? do we have release manager now? If we mention that role, would not be good to talk about who is or are the individuals in docs (or at least give some tip on how to know it)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the release manager for that release. But we are more distributed/chaotic than that, so the release manager is not known until the night of the release. So, perhaps, "release managers" meaning all maintainers?

CONTRIBUTING.md Outdated
planning on including a fix for the ticket in the release.

By contrast, a ticket is milestoned to a given release if we are open to accepting
a fix in that release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(add - i.e. if we would very much appreciate someone working on it, but are not committing to actively sourcing someone to work on it)

@Mikolaj
Copy link
Member

Mikolaj commented Apr 29, 2022

CI seems to be stuck here and randomly failing in another PR, so let me rebase and see how it goes to get a better picture what's going on with our CI.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 29, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

rebase

✅ Branch has been successfully rebased

@Mikolaj
Copy link
Member

Mikolaj commented Apr 29, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

rebase

✅ Branch has been successfully rebased

@ulysses4ever
Copy link
Collaborator

Dear reviewers! I appended a commit addressing your comments. Show time?!

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too, thanks for take care of the pr

@ulysses4ever ulysses4ever added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Jun 27, 2022
@mergify mergify bot merged commit be8ea51 into master Jun 27, 2022
@andreabedini andreabedini deleted the bgamari-patch-1 branch December 14, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants