-
Notifications
You must be signed in to change notification settings - Fork 712
CONTRIBUTING: Describe project and milestone usage #8038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONTRIBUTING.md
Outdated
GitHub conventions | ||
------------------- | ||
|
||
Each `Cabal`/`cabal-install` release has a corresponding GitHub Project and milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Each major"? 3.6.3 doesn't have a project. 3.6 does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't 3.6.3 a minor release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I meant new 3.x numbers, because that seems to be what we really plan for, while 3.x.y are reactive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*major are 3.x numbers
CONTRIBUTING.md
Outdated
|
||
Each `Cabal`/`cabal-install` release has a corresponding GitHub Project and milestone. | ||
A ticket is included in a release's project if the release manager is tenatively | ||
planning on including a fix for the ticket in the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(add -- i.e. if they are actively seeking someone to work on the ticket)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the release manager can do it, then? do we have release manager now? If we mention that role, would not be good to talk about who is or are the individuals in docs (or at least give some tip on how to know it)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the release manager for that release. But we are more distributed/chaotic than that, so the release manager is not known until the night of the release. So, perhaps, "release managers" meaning all maintainers?
CONTRIBUTING.md
Outdated
planning on including a fix for the ticket in the release. | ||
|
||
By contrast, a ticket is milestoned to a given release if we are open to accepting | ||
a fix in that release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(add - i.e. if we would very much appreciate someone working on it, but are not committing to actively sourcing someone to work on it)
CI seems to be stuck here and randomly failing in another PR, so let me rebase and see how it goes to get a better picture what's going on with our CI. |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
d079551
to
1ba5fc2
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
1ba5fc2
to
2fa985f
Compare
2fa985f
to
4468526
Compare
Dear reviewers! I appended a commit addressing your comments. Show time?! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too, thanks for take care of the pr
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!