Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #7874: Add test, fix changelog #7900

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Update #7874: Add test, fix changelog #7900

merged 4 commits into from
Jan 12, 2022

Commits on Jan 8, 2022

  1. Respect ghc-options and with-gcc when compiling C sources 

    This fix allows users to override the C/C++ compiler, either by passing
--with-gcc to configure or adding -pgmc to ghc-options in their Cabal
file.

Tested manually with a project using C++ sources that require a more
recent version of clang than the default install (macOS). Inspected the
output of `Setup.hs build -v` to confirm that the correct arguments are
being passed to GHC when compiling the C++ sources.

Resolves: haskell#4439
    @syntheorem @sergv
    syntheorem authored and sergv committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    25aa866 View commit details
    Browse the repository at this point in the history

  2. Amend changelog

    @sergv
    sergv committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    4354125 View commit details
    Browse the repository at this point in the history

  3. Add test

    @sergv
    sergv committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    1b0fbdc View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. GHCs below 8.8 are not able to pass all the flags we test for

    @sergv
    sergv committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    f45d4fe View commit details
    Browse the repository at this point in the history