-
Notifications
You must be signed in to change notification settings - Fork 712
Cabal: Bump time upper bound to allow 1.12 #7863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can see
@bgamari: could you bump that as well so that we all test the same thing on branch master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarted CI seems to be fine.
I intend to backport this to 3.6 to give the GHC hackers the option of using either branch. I will also make a PR that bumps cabal-install similarly, but not backport it, so that we can dog-food on master ASAP without enddangering 3.6. Please discuss if that doesn't sound good.
CI is not testing this change because time is included with ghc (what was the name for that? core/boot package?) and won't be upgraded... |
@fgaz: well spotted. So we'd need to change the bounds temporarily to only allow 1.12, to get this tested? |
or add time==1.12 to constraints in cabal.project.validate{.libonly}. I don't know if previous maintainers had a faster way to test such changes |
Yes, I tested it in a local GHC tree. |
Historically we have bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tested it in a local GHC tree.
That's enough for me, and the changelog looks harmless
@Mergifyio backport 3.6 |
✅ Backports have been created
|
Cabal: Bump time upper bound to allow 1.12 (backport #7863)
In service of GHC #20547.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!