Skip to content

glob expand extra-src-files when tracking for rebuild (backport #7608) #7767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cabal-install/src/Distribution/Client/SourceFiles.hs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,14 @@
-- we cannot "see" easily.
module Distribution.Client.SourceFiles (needElaboratedConfiguredPackage) where

import Control.Monad.IO.Class

import Distribution.Client.ProjectPlanning.Types
import Distribution.Client.RebuildMonad

import Distribution.Solver.Types.OptionalStanza

import Distribution.Simple.Glob (matchDirFileGlobWithDie)
import Distribution.Simple.PreProcess

import Distribution.Types.PackageDescription
Expand All @@ -35,6 +38,7 @@ import Distribution.ModuleName

import Prelude ()
import Distribution.Client.Compat.Prelude
import Distribution.Verbosity (silent)

import System.FilePath

Expand Down Expand Up @@ -138,13 +142,14 @@ needBuildInfo pkg_descr bi modules = do
-- A.hs-boot; need to track both.
findNeededModules ["hs", "lhs", "hsig", "lhsig"]
findNeededModules ["hs-boot", "lhs-boot"]
expandedExtraSrcFiles <- liftIO $ fmap concat . for (extraSrcFiles pkg_descr) $ \fpath -> matchDirFileGlobWithDie silent (\ _ _ -> return []) (specVersion pkg_descr) "." fpath
traverse_ needIfExists $ concat
[ cSources bi
, cxxSources bi
, jsSources bi
, cmmSources bi
, asmSources bi
, extraSrcFiles pkg_descr
, expandedExtraSrcFiles
]
for_ (installIncludes bi) $ \f ->
findFileMonitored ("." : includeDirs bi) f
Expand Down
10 changes: 10 additions & 0 deletions changelog.d/pr-7608
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
synopsis: Glob expand extra-source-files when tracking for rebuild
packages: cabal-install
prs: #7608
issues: #4746

description: {

- Since 3.4, extra-source-files have been tracked by cabal-install in the rebuild-checking logic. However, this tracking did not, until this PR, take into account glob-expansion.

}