Skip to content

Try to fix CI/Meta-checks failure (backport of #7659) #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Sep 18, 2021

Manual backport of #7659, because it touches CI.

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Sep 18, 2021
@jneira
Copy link
Member

jneira commented Sep 18, 2021

cabal.exe: Unknown target 'cabal-install:memory-usage-tests'.
The package cabal-install has no component 'memory-usage-tests'.

it seems something is missing inthis version

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once ci is happy

@jneira
Copy link
Member

jneira commented Sep 18, 2021

this and #7663 are being blocking themselves

@jneira
Copy link
Member

jneira commented Sep 18, 2021

This pr has only errors in windows due to the network issue, so i am gonna merge this and hopefully will be able to merge #7663 and get a green ci

@jneira jneira merged commit c183ca0 into haskell:3.6 Sep 18, 2021
@Mikolaj
Copy link
Member Author

Mikolaj commented Sep 18, 2021

cabal.exe: Unknown target 'cabal-install:memory-usage-tests'.
The package cabal-install has no component 'memory-usage-tests'.

it seems something is missing inthis version

It's not version, it's branch. Branch 3.6 has one more bug in CI than master. Two PRs were enough to fix CI on master, but their backports (both strengthened) are not enough for 3.6.

@Mikolaj
Copy link
Member Author

Mikolaj commented Sep 18, 2021

this and #7663 are being blocking themselves

You are right. Thank you for merging. This is good order: first CI, then a real bug fix, after it passes corrected CI tests (except for the CI bugs that are not yet corrected).

@jneira
Copy link
Member

jneira commented Sep 18, 2021

cabal.exe: Unknown target 'cabal-install:memory-usage-tests'.
The package cabal-install has no component 'memory-usage-tests'.

it seems something is missing inthis version

It's not version, it's branch. Branch 3.6 has one more bug in CI than master. Two PRs were enough to fix CI on master, but their backports (both strengthened) are not enough for 3.6.

yeah with version i wanted to mean 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants