Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for #5541 #5542

Closed
wants to merge 1 commit into from
Closed

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Aug 23, 2018

No description provided.

@quasicomputational
Copy link
Contributor

I think this also needs a cabal.project in the test directory, or else the outer one (i.e., Cabal's) will be picked up.

@nomeata
Copy link
Contributor Author

nomeata commented Aug 23, 2018

Added.

@phadej
Copy link
Collaborator

phadej commented Aug 23, 2018 via email

@nomeata
Copy link
Contributor Author

nomeata commented Aug 23, 2018

Doesn't feel very nice to have arbitrary amount of files for a test checked-in.

Yeah, maybe… At least they are all the same files, so git will store them only once :-).

If someone wants to go while here, sure. But it’s just a test case…

@typedrat
Copy link
Collaborator

It's 8192 by default on macOS, which is enough I think autogen is justified.

@23Skidoo
Copy link
Member

+1 on autogenerating test data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants