Skip to content

Conversation

@fgaz
Copy link
Member

@fgaz fgaz commented Mar 5, 2018

Now new-install(-nonlocal-exes) should work without issues (if the ~/.cabal/config was generated with this)

Closes #5000 (yay!)

@23Skidoo can we cherry-pick it on 2.2 too?

Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@fgaz fgaz added the cabal-install: v2-build system Affecting v2-build and related commands that use v2-architecture (aka "nix local builds"). label Mar 5, 2018
@fgaz fgaz added this to the 2.2 milestone Mar 5, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Mar 5, 2018

Sure, if it's new-build only, then it's low-risk.

@fgaz
Copy link
Member Author

fgaz commented Mar 5, 2018

Yup. new-build and I set symlink-bindir (which is only used by new-install despite being there for literally 10 years) to ~/.cabal/bin by default in ~/.cabal/config

@hvr
Copy link
Member

hvr commented Mar 5, 2018

I don't give up hope on #680 ... maybe for 3.0? :-)

fgaz added 3 commits March 6, 2018 08:21
It is set to the same directory used by the old cabal install command,
ie `~/.cabal/bin` on linux, as it will be used to "install" (symlink)
executables by new-install.
Before there wasn't much feedback. Most times the only thing that got
printed was "Up to date".
@fgaz fgaz force-pushed the symlinkbindir-config branch from be062a7 to 5e106be Compare March 6, 2018 08:22
@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2018

Merging this now for the same reason as #4825
(travis was green. I stopped it because i forgot [ci skip] when force pushing the changelog)

@fgaz fgaz merged commit b394997 into haskell:master Mar 6, 2018
@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2018

@23Skidoo fyi I just pushed it on 2.2 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cabal-install: v2-build system Affecting v2-build and related commands that use v2-architecture (aka "nix local builds").

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants