Skip to content

Solver test cases #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 19, 2016
Merged

Solver test cases #3359

merged 10 commits into from
Apr 19, 2016

Conversation

grayjay
Copy link
Collaborator

@grayjay grayjay commented Apr 18, 2016

I cherry-picked the solver test cases from open PRs onto the solver branch (See #3357) and added issue numbers. I used tasty-expected-failure to ignore the tests that are currently failing. It doesn't seem to ignore exceptions with GHC 7.8.4, though. I can look into it later, but I didn't want to delay the PR.

/cc @edsko

@kosmikus
Copy link
Contributor

@grayjay Thanks. This looks good to me, but I'll leave merging into solver to @edsko in order not to interfere with his work.

I wouldn't worry about "expected failures" too much for the time being. In fact, in the solver branch, it can even be helpful to have these as explicit failures for now, so that we can be absolutely sure we fix them all.

@edsko edsko merged commit 9bf8e81 into haskell:solver Apr 19, 2016
@edsko
Copy link
Contributor

edsko commented Apr 19, 2016

Merged, many thanks! I agree with @kosmikus , I'd say let the failing test cases just fail. After all, on this branch, if there's something failing, we should really fix it. But it's okay for now.

@grayjay
Copy link
Collaborator Author

grayjay commented Apr 20, 2016

No problem.

After all, on this branch, if there's something failing, we should really fix it. But it's okay for now.

I figured we would remove the dependency on tasty-expected-failure before merging into master, so we wouldn't miss anything.

@grayjay grayjay deleted the solver-test-cases branch April 20, 2016 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants