Fix bug in link validation #3237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are choosing to link a package (`pickLink`), it is possible that that package was _already_ linked (because its reverse dependencies got linked). Thus, this requires a merge of link groups: it is not correct to simply add the package into the target link group. This fixes #2842.
|
@grayjay I think that having them in the repo (even if they were disabled by default) could be useful. |
|
Yup, I agree with @23Skidoo . That would definitely be a good thing to have! |
|
Great! I'll work on a PR. |
|
I've merged these patches to the nix-local-build branch (along with all the other recent solver PRs). |
|
I opened a PR for the quickcheck tests: #3245 |
|
@23Skidoo Would you like me to merge these PRs? |
|
Oh, @kosmikus has said that he will try to review before the release date; I'll hold off then. |
This was referenced Apr 12, 2016
grayjay
referenced
this pull request
in kosmikus/cabal
Apr 21, 2016
|
This has been merged into and subsumed by #3357 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are choosing to link a package (
pickLink), it is possible that that package was already linked (because its reverse dependencies got linked). Thus, this requires a merge of link groups: it is not correct to simply add the package into the target link group.This fixes #2842. Thank you @grayjay for yet another very high quality bug report! All this independent goals/linking is all very new so it's really great to have somebody like you taking such a detailed look at it. Much appreciated!
Pinging @kosmikus and @dcoutts .