Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal check will fail on -fprof-auto passed as a ghc-option #2532

Merged
merged 1 commit into from
Apr 14, 2015

Conversation

cheecheeo
Copy link
Contributor

This is consistent with the the current -auto-all behavior.

This fixes #2479.

Setup:

  % grep -- '-fprof-auto' stats.cabal
    ghc-prof-options: -Wall -fprof-auto -caf-all -threaded "-with-rtsopts=-p"

Before:

  % ../cabal/cabal-install/.cabal-sandbox/bin/cabal check
  No errors or warnings could be found in the package.

After:

  % ../cabal/cabal-install/.cabal-sandbox/bin/cabal check
  These warnings may cause trouble when distributing the package:
  * 'ghc-prof-options: -fprof-auto' is fine during development, but not
  recommended in a distributed package.

This is consistent with the the current -auto-all behavior.

This fixes haskell#2479.
23Skidoo added a commit that referenced this pull request Apr 14, 2015
cabal check will fail on -fprof-auto passed as a ghc-option
@23Skidoo 23Skidoo merged commit 641e854 into haskell:master Apr 14, 2015
@23Skidoo
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal check should cover -fprof-auto
2 participants