Follow hlint suggestion: use typeRep - #11679
Merged
Merged
Conversation
Collaborator
|
I don't think we can use |
ffaf1
approved these changes
Mar 30, 2026
Collaborator
Author
No, not without |
Collaborator
Author
|
MicroHs already supports |
philderbeast
force-pushed
the
hlint/use-typeRep
branch
from
March 31, 2026 12:11
91bc825 to
24c1ea0
Compare
geekosaur
approved these changes
Mar 31, 2026
philderbeast
added
merge me
mergify
Bot
added
ready and waiting
Contributor
Merge Queue Status
This pull request spent 1 hour 38 minutes 50 seconds in the queue, including 1 hour 28 minutes 16 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
86 tasks
Collaborator
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 11 minutes 23 seconds in the queue, including 35 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
86 tasks
Collaborator
|
GHA's throwing network errors again. I'll restart it later. |
Collaborator
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 1 hour 58 minutes 55 seconds in the queue, including 1 hour 47 minutes 11 seconds running CI. Required conditions to merge
|
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. Discharges and no longer ignores HLint's "use typeRep" suggestion so that this will be suggested by our CI linting.
Avoids the use of
undefined.Note
The
Proxy aintestDescribedcould be dropped if we were to use-XRequiredTypeArgumentsbut I'll leave that for the furture. Was interesting to read about and try out this new language extension and see it in action in withshowTypefrom HIW, Vladislav Zavialov - Required Type Arguments.