Skip to content

Fix typo explitic - #11621

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:typo/explitic
Mar 27, 2026
Merged

Fix typo explitic#11621
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:typo/explitic

Conversation

@philderbeast

@philderbeast philderbeast commented Mar 15, 2026

Copy link
Copy Markdown
Collaborator

A follow on from #11501. This changes a couple of data constructors in Cabal.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@philderbeast
philderbeast marked this pull request as draft March 15, 2026 15:42
@philderbeast
philderbeast force-pushed the typo/explitic branch 2 times, most recently from fed50c7 to 0e6c1b0 Compare March 15, 2026 15:48
@philderbeast
philderbeast marked this pull request as ready for review March 15, 2026 15:48

@geekosaur geekosaur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has (finally) occurred to me to wonder if we can define bidirectional pattern synonyms with the old names for constructors like this, and mark them as deprecated so users get warnings. We might then remove them in 3.20. I won't block the PR on that, though.

@philderbeast

philderbeast commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator Author

define bidirectional pattern synonyms with the old names for constructors like this, and mark them as deprecated so users get warnings.

That's possible but I don't think the effort is worth it. I searched GitHub for the typo "CVExpliticDepsCustomSetup" and the only hits were in forks of haskell/cabal. Same goes searching for "CICVExpliticDepsCustomSetup". Within haskell/cabal itself, this constructor is only used within the function:

checkPackageDescription :: Monad m => PackageDescription -> CheckM m ()

@philderbeast

Copy link
Copy Markdown
Collaborator Author

I won't block the PR on that, though.

Thanks @geekosaur.

@philderbeast philderbeast added the merge me Tell Mergify Bot to merge label Mar 25, 2026
@mergify mergify Bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Mar 25, 2026
@mergify

mergify Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 24 minutes 49 seconds in the queue, including 14 minutes 15 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
    • check-success = Bootstrap post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify Bot added a commit that referenced this pull request Mar 27, 2026
@mergify mergify Bot added dequeued and removed queued labels Mar 27, 2026
@geekosaur

Copy link
Copy Markdown
Collaborator

@Mergifyio queue

@mergify

mergify Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 hours 1 minute 45 seconds in the queue, including 1 hour 50 minutes 23 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify mergify Bot added queued and removed dequeued labels Mar 27, 2026
@geekosaur

Copy link
Copy Markdown
Collaborator

That was a new one: communication failure with the runner.

mergify Bot added a commit that referenced this pull request Mar 27, 2026
@mergify
mergify Bot merged commit 96a1e8f into haskell:master Mar 27, 2026
292 of 293 checks passed
@mergify mergify Bot removed the queued label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants