-
Notifications
You must be signed in to change notification settings - Fork 723
Preflight checks for 3.16 (Backport #11275) #11280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@geekosaur Am I supposed to bump We do not yet have Maybe the bump is to be done in Bumping version numbers? |
|
This still needs to be bumped so it is 3.16.1.0, at which point the constraint in |
|
Yes, but should this be done in this step? @ulysses4ever |
|
It belongs in "bumping version numbers". I'm just reminding everyone that it needs to be done so we don't release something that will fail |
|
Thanks. CI is failing, I am not sure why, I will investigate. |
this doesn't look good |
|
I would suggest flushing the cache, but we go through our allotment so quickly that it happens by itself. Which makes me wonder if one of their runners is running a different version somehow. (I note that other GHC versions succeeded, and it's specifically the Sadly I'm running 25.04 currently so I can't really check this locally. All I can suggest is that those versions may need to be tested on 22.04 instead. |
|
Okay, this is odd: I checked my system and |
|
Oh, ugh, even worse: they're already on 22.04. I'm tempted to suggest asking GitHub what's up. |
|
|
Yeh, I saw the |
It's cabal/cabal-validate/cabal-validate.cabal Line 45 in fbc055e
I suggest relaxing this to |
44822bc to
18a7beb
Compare
|
Okay, now I'm really confused. I saw @ffaf1 restarted CI a couple times to see if the failure was transient. But now it's passing, and what I added can't possibly have affected the build (it just does a |
|
I'm going to hate myself (or more likely GitHub) for this, right? |
18a7beb to
090ade5
Compare
|
Okay, I have zero idea what GitHub changed to either cause or fix the problem, but it does appear to be fixed. @ffaf1, maybe push this in before they break it again? 😁 |
Include the following checklist in your PR:
If so, it will need to be backported to older cabal release branches (ask maintainers for directions).