Apply hlint suggestions with a single count #11093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
I am mostly relying on ghc here, with some spot checks: if the result compiles it is most probably correct. (Almost all failures with applying hlint suggestions involve things like the result having an ambiguous type, because hlint works by source heuristics and doesn't know about types at all.)
Yes me too. I |
philderbeast
force-pushed
the
hlint/onesies
branch
2 times, most recently
from
06b4a14 to
dc5c969
Compare
Bodigrim
reviewed
Jul 30, 2025
Bodigrim
approved these changes
Jul 31, 2025
- Follow hlint suggestion: Use isJust - Follow hlint suggestion: Use isNothing - Follow hlint suggestion: Redundant == - Follow hlint suggestion: Redundant fmap - Follow hlint suggestion: Use minimumBy - Follow hlint suggestion: Use lefts - Follow hlint suggestion: Use fromRight - Follow hlint suggestion: Use for - Follow hlint suggestion: Use forM_ - Follow hlint suggestion: Use when - Follow hlint suggestion: Use uncurry - Follow hlint suggestion: Use traverse - Follow hlint suggestion: Use ?~ - Follow hlint suggestion: Fuse traverse_/map - Follow hlint suggestion: Fuse traverse_/fmap - Follow hlint suggestion: Use replicateM - Follow hlint suggestion: Missing NOINLINE pragma - Rerun hlint --default - Redo hlint counts after rebase - Use Data.Foldable.minimumBy Co-Authored-By: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com>
philderbeast
force-pushed
the
hlint/onesies
branch
from
2a76f61 to
7b67d02
Compare
philderbeast
added
merge me
mergify
bot
added
ready and waiting
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9110. Apply hlint suggestions with a single count so that these warnings are no longer ignored and will be picked up by our CI linting.
I left one or two single count warnings that didn't have a small diff or that I didn't think would be otherwise easy to review.
Each applied suggestion is an individual commit but I'll squash these if this pull request is approved.
When reviewing #8889, we noticed that plenty of hlint suggestions were being ignored in
.hlint.yamlthat would have been triggered for new modules and new code of #8889.