-
Notifications
You must be signed in to change notification settings - Fork 710
Clarify role of ~/.cabal when determining config file. #10972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This is purely a documentation change that makes the behaviour more explicit. The actual behaviour is unchanged, although the need for a five step checklist to find the config file suggests that perhaps things have gotten a bit out of hand.
Python is acting up. Let me restart the failed CI jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formally speaking, this should close #10713, which was a purely documentation inquiry. But I see an active discussion there, so up to you...
This is explicitly a follow-on to that issue, and is not a final solution as discussion continues about possibly simplifying the behavior. |
@athas merge label? |
all right, I'll take the liberty to put the merge label... |
actually, @Bodigrim, can you take a look first? It was your issue, so it'd be good to have your opinion here. |
I don't understand what is expected of me here. I think this should be merged; otherwise I would have made the PR a draft. |
@athas as per https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions the PR author is expected to put one of the merge labels when they feel like the PR should be merged. |
This is purely a documentation change that makes the behaviour more explicit.
The actual behaviour is unchanged, although the need for a five step checklist to find the config file suggests that perhaps things have gotten a bit out of hand.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: