Cabal: Honour -working-dir flag when running test executables#10725
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Jan 12, 2025
Merged
Cabal: Honour -working-dir flag when running test executables#10725mergify[bot] merged 1 commit intohaskell:masterfrom
mergify[bot] merged 1 commit intohaskell:masterfrom
Conversation
Collaborator
|
Excellent, thanks @mpickering. Is there a similar bug in the code for running benchmarks? IIRC that code is very similar. |
Collaborator
Author
|
Benchmarks look to be fine. I'll extend the test anyway. |
sheaf
approved these changes
Jan 8, 2025
Collaborator
|
Needs only a merge label now after two reviews. |
Member
|
@mpickering: would you like to set the merge label? it's a way of saying you don't want to add anything else to the PR (label needs-review only says it's ready enough to be reviewed). |
A simple fix to run the test executable in the `-working-dir`. Fixes haskell#10704
This was referenced Mar 27, 2025
Member
|
@mergify backport 3.14 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 27, 2025
Backport #10725: Cabal: Honour -working-dir flag when running test executables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix to run the test executable in the
-working-dir.Fixes #10704
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.