Add cfgVerbosity

[philderbeast]

I was working on a fix for #10527 and noticed that all but one of the callers of withContextAndSelectors had already accessed verbosity in the same way that withContextAndSelectors does (Cmd*.hs modules do this):

cabal/cabal-install/src/Distribution/Client/CmdRepl.hs

Line 509 in 62073c9

verbosity = fromFlagOrDefault normal (setupVerbosity $ configCommonFlags configFlags)

cabal/cabal-install/src/Distribution/Client/ScriptUtils.hs

Line 340 in 62073c9

verbosity = fromFlagOrDefault normal (setupVerbosity $ configCommonFlags configFlags)

This is a refactor that adds a verbosity argument to withContextAndSelectors and a function cfgVerbosity that simplifies grabbing the verbosity from the configuration or using a default value.

With this a lot of -XRecordWildCards can be removed as can a lot of imports from Distribution.Client.Setup.

This will help with my fix for #10527 too as I may have to call withContextAndSelectors twice¹ and don't want repeated messaging so would silence the verbosity of the first call.

Configuration is affected by the following files:
- cabal.project
Configuration is affected by the following files:
- cabal.project

---

• Patches conform to the coding conventions.
• Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Footnotes

1. Depending on whether cabal repl should pick the one target, Should cabal repl pick the one package library as TARGET? #10689. ↩

[ffaf1]

Why is this appearing twice in the output?

[Mikolaj]

@philderbeast: any comment?

[philderbeast]

I've marked this as blocked until I can answer the question from @ffaf1, #10688 (comment). I want to check some other branches of mine to find the code snippet that will help with an explanation.