Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type signature and documentation to toSavedConfig #10413

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add type signature and documentation to toSavedConfig #10413

merged 1 commit into from
Oct 7, 2024

Conversation

9999years
Copy link
Collaborator

This helper function was challenging to understand, so I added an explicit type signature and documentation comments to it.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@9999years 9999years changed the title Add type and documentation to toSavedConfig Add type signature and documentation to toSavedConfig Oct 2, 2024
@9999years 9999years added the merge me Tell Mergify Bot to merge label Oct 2, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 2, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 4, 2024
@9999years @Mikolaj
Add type and documentation to toSavedConfig
5a65cdd 
This helper function was challenging to understand, so I added
an explicit type signature and documentation comments to it.
@mergify mergify bot merged commit cc618ff into haskell:master Oct 7, 2024
48 checks passed
@geekosaur
Copy link
Collaborator

geekosaur commented Oct 7, 2024 •
edited
Loading

So this one at least ran all checks to completion before merging. But it was only one file, so it wouldn't have triggered the skip job.

@9999years 9999years deleted the document-to-saved-config branch October 7, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@9999years @geekosaur @ulysses4ever @ffaf1