Fix withFileContents documentation (lazy IO strikes again)#10389
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Sep 30, 2024
Merged
Conversation
9999years
force-pushed
the
wiggles/fix-withfilecontents-comment
branch
from
17017d2 to
892ef46
Compare
geekosaur
approved these changes
Sep 27, 2024
5 tasks
ulysses4ever
approved these changes
Sep 28, 2024
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
A little unit test may be a good idea, but in honesty, the lazy IO caveats will paper-cut people anyway...
mergify
bot
added
ready and waiting
The documentation for `Distribution.Utils.Generic.withFileContents` is incorrect:
$ cabal repl Cabal-syntax
ghci> import Distribution.Utils.Generic
ghci> withFileContents "README.md" $ \contents -> pure ("foo" `isInfixOf` contents)
*** Exception: README.md: hGetContents: illegal operation (delayed read on closed handle)
9999years
force-pushed
the
wiggles/fix-withfilecontents-comment
branch
from
892ef46 to
76d5f2f
Compare
Collaborator
Author
|
No rebase label to fix the mergify check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for
Distribution.Utils.Generic.withFileContentsis incorrect: