Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cabal-install:long-tests with Git >=2.38.1 #10329

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

9999years
Copy link
Collaborator

Closes #10312.

Git 2.38.1 and newer fails to clone from local paths with fatal: transport 'file' not allowed unless protocol.file.allow=always is set.

This is not safe in general, but it's fine in the test suite.

See: https://github.blog/open-source/git/git-security-vulnerabilities-announced/#fn-67904-1
See: https://git-scm.com/docs/git-config#Documentation/git-config.txt-protocolallow

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@9999years 9999years marked this pull request as ready for review September 6, 2024 20:36
@9999years 9999years added the merge me Tell Mergify Bot to merge label Sep 6, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 6, 2024
Closes haskell#10312.

Git 2.38.1 and newer fails to clone from local paths with `fatal:
transport 'file' not allowed` unless `protocol.file.allow=always` is
set.

This is not safe in general, but it's fine in the test suite.

See: https://github.blog/open-source/git/git-security-vulnerabilities-announced/#fn-67904-1
See: https://git-scm.com/docs/git-config#Documentation/git-config.txt-protocolallow
@mergify mergify bot merged commit b09b118 into haskell:master Sep 8, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests fail with Git 2.38.1 and later
3 participants