Skip to content

unsafeFromUTF8BS in D.FieldGrammar.Parsec is wrong #6587

Closed
@phadej

Description

@phadej

The bytestring can in fact be invalid UTF8, previously when parsing to String we did conversion using fromUTF8BS which leniently fixed the text using replacement character.

I'm not sure what to do here. Eq is broken but can be worked around in tests (I'll push a commit soon). Conversion of ShortText to String introduces replacement characters as well.

Performance wise one would like to do nothing, we don't compare free text fields for equality inside Cabal.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions