Skip to content

Add Binary instance for Identity, from base-4.8.0.0 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2018
Merged

Add Binary instance for Identity, from base-4.8.0.0 #146

merged 2 commits into from
Jun 7, 2018

Conversation

Daniel-Diaz
Copy link

@Daniel-Diaz Daniel-Diaz commented Mar 12, 2018 •
edited
Loading

The module Data.Functor.Identity was added in base-4.8.0.0. Using CPP conditionals, I added a Binary instance for the Identity type.

Thanks.

@Daniel-Diaz
Copy link
Author

I think the errors in travis are not related to my changes.

@int-index
Copy link
Contributor

I think the errors in travis are not related to my changes.

@Daniel-Diaz You might try rebasing onto master, the Travis failure was fixed in #147

@Daniel-Diaz
Copy link
Author

OK. I updated my fork.

@kolmodin kolmodin merged commit ecf48c4 into haskell:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-Diaz @int-index @kolmodin