-
Notifications
You must be signed in to change notification settings - Fork 329
Higherkinded special strings #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
andrewthad
wants to merge
14
commits into
haskell:master
from
andrewthad:higherkinded_special_strings
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f7d2194
Add lifted typeclasses and some instances
phadej 216557b
Add few more ToJSON1/FromJSON1 instances
phadej 87cc558
Add unary instances to Monoid newtypes
phadej 95e7c57
Add unary instances for vector
phadej e4aecbb
Unary and Binary tuple instances
phadej a3b0a73
Cleanup primed functions
phadej 832dd74
List instance
phadej 206212c
Issue 351 regression change
phadej 1b4102c
Fix merge conflict from merging list-instance into master
andrewthad 2587f03
Fix merge conflicts resulting from merging in higher kinded typeclasses
andrewthad 328e18b
Higher kinded json classes now preserve String behavior
andrewthad b739ec0
Add listParser and rename list to listEncoding
andrewthad 03ee297
Fix merge conflicts
andrewthad ffe80ba
Add higher kinded instances for Map and HashMap
andrewthad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps
list
should be renamed tolistEncoding
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I had only left it named
list
here because I stole it out ofData.Aeson.Encode.Functions
, butlistEncoding
is a much better name.