Add Data.Aeson.Decoding.Text, decodeStrictText :: Text -> ... #1072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid intermediate ByteString copy by not doing
decode . TE.encodeUtf8
, but instead working onText
value directly. As we know that the stream is valid Unicode (UTF8 or UTF16), we can also take some shortcuts.One gotcha is that internal Text values (in Keys or Value Strings) most likely retain the original input
Text
value (its Array). It shouldn't be an issue if the Value is actually decoded so theseText
values disapper, but if not (e.g.Object
keys survive) then users might want to useData.Text.copy
.With GHC-9.6.2 (text-2.0.2; UTF-8) the speedup is not huge, but noticeable anyway:
With GHC-8.6.5 (text-1.2.3.0; UTF-16) the speedup is relatively more: