Add a way to specify authentication to the registry #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I need to produce a message to a Confluent kafka using a schema registry, and as I mentioned in the issue #37 there doesn't seem to be a way to connect to a registry that needs credentials.
That's why I modified the SchemaRegistry constructor to include the
Maybe Authand propagate it across the different requests.To keep compatibility with the previous API I've left the
schemaRegistryfunction as is, and added a new one calledschemaRegistry_. Let me know if this is ok, or if you have some contribution guidelines that I need to follow.This is my first PR to a Haskell repo :)