Fix Travis #243
Merged
Fix Travis #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
commented
Dec 12, 2019
| bytestring, | ||
| containers, | ||
| criterion, | ||
| gauge, |
Member
Author
There was a problem hiding this comment.
Not sure whether this file can be removed now that the dependency cycle has been removed?
Member
Author
|
Ping! :) |
Collaborator
|
Please squash into one or a very few logical commits. Please justify the switch to |
* Add jobs using GHC 8.6 and 8.8. * Benchmarks are compiled with GHC >= 7.10. This is simplified by using gauge instead of criterion, which removes a dependency cycle.
Member
Author
Done! |
Collaborator
|
I don't love losing features relative to Criterion, but the dependency cycles are admittedly a bit wonky to deal with. Fine. |
Member
Author
|
@treeowl Thanks for reviewing and merging! Which |
Collaborator
|
Pretty graphs, mostly. |
Member
Author
You could give https://github.com/composewell/bench-show a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building the tests with GHC-7.8 by removing the constraints to build with the installed versions of
containersandbinary.Benchmark builds are simplified by switching from
criteriontogauge.This also adds jobs with GHC-8.6 and 8.8.