Skip to content

Fix documentation hierarchy #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

eyeinsky
Copy link
Contributor

From this issue #1443

(Added also the nix section header at the bottom so the existing paragraph would be easier to sight.)

@eyeinsky
Copy link
Contributor Author

Looks like this now:

Screenshot_2021-08-28_17-25-50

Copy link
Contributor

@alpmestan alpmestan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@akhesaCaro
Copy link
Contributor

akhesaCaro commented Sep 7, 2021

To support older version of GHC you need to explicitly import the <> operator.

import Data.Semigroup (<>)

You can also test it using the nix-shell (nix/nix-shell) and provide the version of GHC you want to use. See https://github.com/haskell-servant/servant/tree/master/nix

@eyeinsky
Copy link
Contributor Author

Found a typo. (And though I pushed to my fork of the repo, github appears to have picked up the commit here too.)

@akhesaCaro
Copy link
Contributor

akhesaCaro commented Oct 2, 2021

This PR needs to be rebase. The CI will not build it in GHC < 8.6.5 anymore.

@gdeest
Copy link
Contributor

gdeest commented Oct 11, 2021

Hmmm, I tried rebasing the branch but accidentally pushed current master on your branch instead of my rebase and GitHub seems to have interpreted this as a request to close the PR — not sure why but I can't push on your remote anymore.

Reopening the PR with my branch (sorry about this).

@gdeest
Copy link
Contributor

gdeest commented Oct 11, 2021

#1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants