Skip to content

enabling hoist-server-with-context cookbook #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

akhesaCaro
Copy link
Contributor

@akhesaCaro akhesaCaro commented Apr 10, 2021

Related to #1411

Enabling hoist-server-with-context cookbook

Compability with GHC 8.0.2 has been dropped because servant-auth-server-0.4.4.0 isn't compatible with it anymore. See : haskell-servant/servant-auth@90d14b4

@akhesaCaro akhesaCaro changed the title renabling hoist-server-with-context cookbook enabling hoist-server-with-context cookbook Apr 10, 2021
@akhesaCaro akhesaCaro force-pushed the cookbook_hoist_server_with_context branch 3 times, most recently from 2fd3676 to 1135500 Compare April 11, 2021 05:38
@akhesaCaro
Copy link
Contributor Author

With GHC 8.0.2

src/Servant/Auth/Server/Internal/ThrowAll.hs:5:48: error:
Error:     Module Servant does not export ServantErr
cabal: Failed to build servant-auth-server-0.1.0.1 (which is required by
exe:cookbook-hoist-server-with-context from
cookbook-hoist-server-with-context-0.0.1).

Error: Process completed with exit code 1.

@akhesaCaro akhesaCaro marked this pull request as ready for review April 11, 2021 05:59
Copy link
Contributor

@gdeest gdeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdeest
Copy link
Contributor

gdeest commented Apr 15, 2021

@akhesaCaro You may want to clean history a bit. I am not sure why it is showing your changes as a merge commit…

@akhesaCaro akhesaCaro force-pushed the cookbook_hoist_server_with_context branch from 1135500 to 97967d8 Compare April 16, 2021 11:39
@akhesaCaro akhesaCaro merged commit ad76c47 into haskell-servant:master Apr 16, 2021
@akhesaCaro akhesaCaro deleted the cookbook_hoist_server_with_context branch April 16, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants