Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link emphasis on Downloads page #241

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

Martinsos
Copy link
Contributor

@Martinsos Martinsos commented Jan 29, 2023

What happened here is that I removed "btn-primary" class from the 4 buttons at the bottom of the Downloads page, where each of these buttons on click expands into detailed instructions for installation of Haskell toolchain via native OS package manager for specific distribution.

Instead, I put it on GHCup, which is the recommended installation method.

This is what it looked like before:

image

This is what it looks like now:

image

I removed it because I felt confident that it was a mistake in the earlier design. The main thing we want visitors to focus on this page is GHCup, then explanation of the toolchain, and only then potentially the installations via native OS package manager. So it is the part of the page that we want to attract the least of the attention, we even have text that says this method of installation is not recommended and should ideally not be used, but then it uses the btn-primary class, which is to be used for the buttons that should be most emphasized, usually used for the CTA (Call To Action) button -> which in this case is GHCup.

I also added one <br> before the horizontal line, to make it clearer that recommended installation instructions stop here.

@Martinsos Martinsos changed the title Remove button emphasis on non-recommended installation methods. Fix link emphasis on Downloads page Jan 29, 2023
@TikhonJelvis TikhonJelvis merged commit 94a7061 into haskell-infra:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants