Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New encoding options: encUseCrLf and encIncludeHeader #52

Merged
merged 1 commit into from
Apr 24, 2014

Conversation

pjones
Copy link
Contributor

@pjones pjones commented Apr 24, 2014

  • encUseCrLf: Controls the record separator when encoding. The
    default is True which preserves the current behavior of using \r\n.
    Using False changes the behavior to use \n.
  • encIncludeHeader: Allow control over whether a header row is
    included when encoding records. The default is True to maintain
    current behavior. This allows records to be encoded in a streaming
    fashion. The first batch of encoded records can include a header,
    and remaining batches can omit it.

  * encUseCrLf: Controls the record separator when encoding.  The
    default is True which preserves the current behavior of using \r\n.
    Using False changes the behavior to use \n.

  * encIncludeHeader: Allow control over whether a header row is
    included when encoding records.  The default is True to maintain
    current behavior.  This allows records to be encoded in a streaming
    fashion.  The first batch of encoded records can include a header,
    and remaining batches can omit it.
@pjones
Copy link
Contributor Author

pjones commented Apr 24, 2014

I just wanted to note that I added strictness annotations to the new members of the EncodeOptions type because the existing field already had one. I also thought about adding an INLINE pragma for the new recordSep function but though it would be a bit premature and it would be best to leave that up to you.

Thanks!

@tibbe tibbe merged commit fdeafad into haskell-hvr:master Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants