Make fileBlobUrl and fileRawUrl optional; Fix #339. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are null for the diff api when a commit removes a submodule. Add test that uses the repository I created to test this issue. Remove two redundant imports due to fix warnings.
|
This resolves #339 |
phadej
reviewed
Oct 30, 2018
| @@ -184,9 +184,9 @@ instance NFData GitUser where rnf = genericRnf | |||
| instance Binary GitUser | |||
|
|
|||
| data File = File | |||
| { fileBlobUrl :: !URL | |||
| { fileBlobUrl :: !(Maybe URL) | |||
There was a problem hiding this comment.
won't we be on safer ground if FromJSON instance is changed to use :? for changed fields?
Otherwise LGTM
There was a problem hiding this comment.
Good catch. Added in b4422b0
|
@phadej Would you mind merging this or letting me know what needs changing? Currently we are using a fork of this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to the
Filetype.These fields are null for the diff api when a commit removes a submodule.
Add test that uses the repository I created to test this issue.
Remove two redundant imports to fix warnings.