Stop all processes in closeLocalNode. #187
Conversation
|
Still experience some deadlocks, I'll have to recheck. |
|
Yes, just one exception please. |
|
Ok, but there is a problem that process could recover from exception, however it should not recover from |
|
Updated, only one exception is sent to the process, also I left |
| where | ||
| terminateProcesses :: IO (IO ()) | ||
| terminateProcesses = do | ||
| st <- modifyMVar (localState node) (\st -> return (st, st)) |
There was a problem hiding this comment.
Or much more simply, just readMVar?
There was a problem hiding this comment.
Taken from original code, I agree that it should be simplified.
|
This change would moreover warrant an accompanying test. |
|
All tests are ready but I need to review them myself PR will be opened this night. |
|
I have addressed all comments except request for additional test (as it will be done later and linked to this PR) and comment about potential loop. |
|
Ok let me compare them two approaches now. Sorry for the delay! |
|
Closing in favor of #188. Reason: another approach is simpler and give required guarantees, the only issue connected with n-t-backed implementation, and should not be workarounded on d-p level. |
No description provided.