Fix/spawn async #17
Merged
Fix/spawn async #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facundominguez please check this PR, I've extended commit message and rebased it on the top of the current work. |
| here <-getSelfNode | ||
|
|
||
| ev <- try $ spawnAsync here (error "boom") | ||
| liftIO $ putStrLn "here" |
There was a problem hiding this comment.
Remove or make it more meaningful.
|
👍 Maybe d-p should have a test suite for internal functions like |
Add test that checks if spawnAsync evaluates message to HNF, and throws exception outside of NC.
|
I agree with possible introduction of test in d-p but I'd like to discuss what should be there before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend test-suite with test for already merged PR