add underscore to HCL function identifier regex #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. While I realize that this is similar to #185 which was closed, I believe that just adding the underscore will keep the regex idiomatic while covering common, real-world cases.
The HCL spec here:
https://github.com/hashicorp/hcl/blob/main/hclsyntax/spec.md#identifiers
contains the following paragraph:
I believe this sufficiently implies that the use of
_
as an idiomatic word-separator character in identifiers.Additionally, we can see real-world adoption of this practice in projects like Terragrunt, which use the underscore as a word separator for built-in functions: https://terragrunt.gruntwork.io/docs/reference/built-in-functions/