Skip to content

Conversation

@TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

With the next release being 0.3, deprecated code should be removed

@TimDiekmann TimDiekmann requested a review from indietyp November 24, 2022 06:29
@github-actions github-actions bot added the area/libs > error-stack Affects the `error-stack` crate (library) label Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1485 (194e256) into main (0e4646f) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   44.84%   44.57%   -0.27%     
==========================================
  Files         315      315              
  Lines       17328    17226     -102     
  Branches      813      813              
==========================================
- Hits         7770     7678      -92     
+ Misses       9553     9543      -10     
  Partials        5        5              
Flag Coverage Δ
error-stack 90.80% <100.00%> (+0.03%) ⬆️
unit-tests 1.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/libs/error-stack/src/fmt/hook.rs 89.61% <ø> (ø)
packages/libs/error-stack/src/fmt/mod.rs 95.12% <ø> (-0.05%) ⬇️
packages/libs/error-stack/src/frame/mod.rs 75.00% <ø> (+1.31%) ⬆️
packages/libs/error-stack/src/hook.rs 100.00% <ø> (+8.16%) ⬆️
packages/libs/error-stack/src/lib.rs 38.46% <ø> (ø)
packages/libs/error-stack/src/result.rs 88.70% <ø> (+4.09%) ⬆️
packages/libs/error-stack/src/compat/anyhow.rs 94.73% <100.00%> (-0.72%) ⬇️
packages/libs/error-stack/src/compat/eyre.rs 94.11% <100.00%> (-0.33%) ⬇️
packages/libs/error-stack/src/frame/frame_impl.rs 89.74% <100.00%> (-1.81%) ⬇️
packages/libs/error-stack/src/report.rs 88.81% <100.00%> (-1.36%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

indietyp
indietyp previously approved these changes Nov 24, 2022
@TimDiekmann TimDiekmann added the meta/changelog Needs to be added to a changelog label Nov 24, 2022
@TimDiekmann TimDiekmann merged commit 9e1d734 into main Nov 24, 2022
@TimDiekmann TimDiekmann deleted the td/es/remove-deprecations branch November 24, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs > error-stack Affects the `error-stack` crate (library) meta/changelog Needs to be added to a changelog

Development

Successfully merging this pull request may close these issues.

3 participants