-
Notifications
You must be signed in to change notification settings - Fork 8
Update v202505-1.mdx to include Podman warning #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As per discussion with engineering, add a warning to the current release page to highlight the potential discrepancy between our calculated container digest, and podman's reported digest.
@rkoron007 moved PR over from previous repo as requested. |
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🫛
@@ -10,6 +10,7 @@ Last required release: [v202406-1 (776)](/terraform/enterprise/releases/2024/v20 | |||
|
|||
Flexible Deployment Options `terraform-enterprise` container digest: amd64/linux `sha256:4d31e2698e1ca2deb945a491d61f6bc914c0eb6e385e737a028b897a3eda4a63` | |||
|
|||
~> Users pulling images and validating digests with podman should note that there is an [outstanding issue](https://github.com/containers/podman/issues/25361) that may cause podman to misreport the container digest to the user. The recommended workaround until this is resolved is to pull by container digest directly. `podman pull images.releases.hashicorp.com/hashicorp/terraform-enterprise@sha256:4d31e2698e1ca2deb945a491d61f6bc914c0eb6e385e737a028b897a3eda4a63` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benemon I'm going to play around with a few formatting options before I make a suggestion here! It'll make a minute since I can't build locally right now (here is my preview PR), but wanted to let you know I'll make a formatting suggestion here before the day is out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into it more, and unfortunately we don't currently have a fix for the style breaking.
I agree having the command is super useful, and probably what folks want to see. Do you think it'd be enough to leave it at the top of the page without a callout? Maybe even adding an emoji since this is important and we do wanna catch the eye?
~> Users pulling images and validating digests with podman should note that there is an [outstanding issue](https://github.com/containers/podman/issues/25361) that may cause podman to misreport the container digest to the user. The recommended workaround until this is resolved is to pull by container digest directly. `podman pull images.releases.hashicorp.com/hashicorp/terraform-enterprise@sha256:4d31e2698e1ca2deb945a491d61f6bc914c0eb6e385e737a028b897a3eda4a63` | |
⚠️ If you are using Podman to deploy Terraform Enterprise, there is an [outstanding issue](https://github.com/containers/podman/issues/25361) that can cause Podman to misreport your container digest. In the meantime, we recommend pulling the container digest with `podman` directly: | |
```shell-session | |
> podman pull images.releases.hashicorp.com/hashicorp/terraform-enterprise@sha256:4d31e2698e1ca2deb945a491d61f6bc914c0eb6e385e737a028b897a3eda4a63 | |
`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I omitted the last backtick on code block in this suggestion so it wouldn't break the suggestion format -- if you like the suggestion you'd just need to add one more backtick at the bottom!)
As per discussion with engineering, add a warning to the current release page to highlight the potential discrepancy between our calculated container digest, and podman's reported digest.