Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation manager plugin logs in case of storage errors #29634

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

vinay-gopalan
Copy link
Contributor

Description

Only logs a certain error if Rotation Manager operations were performed. Moves the log into the if block as it was incorrectly placed before.

@vinay-gopalan vinay-gopalan requested a review from a team as a code owner February 13, 2025 22:38
@vinay-gopalan vinay-gopalan added this to the 1.19.0-rc milestone Feb 13, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 13, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@vinay-gopalan vinay-gopalan merged commit 6a9de17 into main Feb 13, 2025
102 of 104 checks passed
@vinay-gopalan vinay-gopalan deleted the vinayg/automated-root-rotation-fix-log branch February 13, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants