UI: MFA methods now display namespace_path instead of namespace_id #29588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lane-wetmore
added
ui
backport/1.18.x
backport/ent/1.17.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
lane-wetmore
added
backport/1.19.x
and removed
backport/1.18.x
backport/ent/1.17.x+ent
hellobontempo
requested changes
Feb 13, 2025
lane-wetmore
requested review from
hellobontempo
and removed request for
cinthiaconti
lane-wetmore
added
backport/1.18.x
backport/ent/1.17.x+ent
hellobontempo
approved these changes
Feb 13, 2025
drivera258
pushed a commit
that referenced
this pull request
Feb 13, 2025
…29588) * update mfa methods to use namespace_path instead of namespace_id * add test for empty namespace path and add namespace path to factories * add changelog entry * fix name * hide namespace label when path is empty and test updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
The namespace label for MFA method items previously showed the namespace id. This changes it to show the namespace path instead.
Before:
After:
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.