-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 1.19.x to versions #29565
add 1.19.x to versions #29565
Conversation
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: we should add !.release/versions.hcl
to .gitignore too:
diff --git a/.gitignore b/.gitignore
index fc59cf7fa8..160a17c94a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -54,6 +54,7 @@ Vagrantfile
!.copywrite.hcl
!.release/ci.hcl
!.release/security-scan.hcl
+!.release/versions.hcl
!.release/linux/package/etc/vault.d/vault.hcl
!enos/**/*.hcl
!**/test-fixtures/**/*.hcl
version "1.19.x" { | ||
ce_active = true | ||
lts = true | ||
} | ||
version "1.18.x" { | ||
ce_active = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should 1.18.x be marked as ce_active = false
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally we do that after the final release.
CI Results: |
Co-authored-by: davidadeleon <ddeleon@hashicorp.com>
Co-authored-by: davidadeleon <ddeleon@hashicorp.com>
Description
This PR adds 1.19.x to the versions file to allow for backports.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.