Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 1.19.x to versions #29565

Merged
merged 1 commit into from
Feb 12, 2025
Merged

add 1.19.x to versions #29565

merged 1 commit into from
Feb 12, 2025

Conversation

davidadeleon
Copy link
Contributor

Description

This PR adds 1.19.x to the versions file to allow for backports.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@davidadeleon davidadeleon requested review from a team as code owners February 11, 2025 22:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 11, 2025
@davidadeleon davidadeleon added this to the 1.19.0-rc milestone Feb 11, 2025
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we should add !.release/versions.hcl to .gitignore too:

diff --git a/.gitignore b/.gitignore
index fc59cf7fa8..160a17c94a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -54,6 +54,7 @@ Vagrantfile
 !.copywrite.hcl
 !.release/ci.hcl
 !.release/security-scan.hcl
+!.release/versions.hcl
 !.release/linux/package/etc/vault.d/vault.hcl
 !enos/**/*.hcl
 !**/test-fixtures/**/*.hcl

version "1.19.x" {
ce_active = true
lts = true
}
version "1.18.x" {
ce_active = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 1.18.x be marked as ce_active = false now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we do that after the final release.

@davidadeleon davidadeleon enabled auto-merge (squash) February 11, 2025 23:52
Copy link

CI Results:
All Go tests succeeded! ✅

@davidadeleon davidadeleon merged commit 751ee0d into main Feb 12, 2025
95 of 99 checks passed
@davidadeleon davidadeleon deleted the davidadeleon/update-manifest branch February 12, 2025 00:28
drivera258 pushed a commit that referenced this pull request Feb 12, 2025
Co-authored-by: davidadeleon <ddeleon@hashicorp.com>
drivera258 pushed a commit that referenced this pull request Feb 12, 2025
Co-authored-by: davidadeleon <ddeleon@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants