Vault 27392 log ldap warning - remove from warning from response

[hashiblaum]

Description

What does this PR do?

This PR removes LDAP warnings from API response when trying to authenticate with LDAP and instead logs them at the Warning log level

JIRA: https://hashicorp.atlassian.net/browse/VAULT-27392

[github-actions]

CI Results:
All Go tests succeeded! ✅

[github-actions]

Build Results:
All builds succeeded! ✅

[fairclothjm]

Do we also plan to make the changes to the hashicorp/cap library as mentioned in the Jira?

[hashiblaum]

Do we also plan to make the changes to the hashicorp/cap library as mentioned in the Jira?

@fairclothjm it didn't seem necessary to modify the hashicorp/cap library, which provides the ldap client and returns the slice of warnings, which seems helpful to any consumer of the ldap client. For the requirement to modify how the end user receives the warnings, it appeared that the change was only needed in the LDAP plugin

[fairclothjm]

@hashiblaum Thanks, I see what you mean.

Can we also add a changelog of type change and set the GH Milestone to 1.19.0-rc?

[hashiblaum]

@hashiblaum Thanks, I see what you mean.

Can we also add a changelog of type change and set the GH Milestone to 1.19.0-rc?

@fairclothjm thanks, I added the changelog with the type change. Interestingly when using the go-changelog tool it doesn't provide that type to use so I had to do it manually

[fairclothjm]

I took another look at the Jira and we should also remove the AddWarning call on Line 124.

[fairclothjm]

LGTM!

[fairclothjm]

Looks like a failing test?

=== FAIL: builtin/credential/ldap TestBackend_basic_nogroupdn (3.93s)
...
    testing.go:367: Failed step 5: expected a warning due to no group dn, got: []string(nil)
...

https://github.com/hashicorp/vault/actions/runs/12657568986/job/35272697843?pr=29134

[fairclothjm]

LGTM!