UI: Handle deprecation router service from host #28281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
hashishaw
changed the base branch from
ui/VAULT-30635/handle-ember-cli-deprecations
to
main
hashishaw
changed the base branch from
main
to
ui/VAULT-30635/handle-ember-cli-deprecations
…AULT-30635/deprecation-router-service-from-host
Monkeychip
reviewed
Sep 11, 2024
There was a problem hiding this comment.
🥳 thank you for adding.
There was a problem hiding this comment.
probably need the copyright header on this file.
Monkeychip
reviewed
Sep 11, 2024
Monkeychip
reviewed
Sep 11, 2024
There was a problem hiding this comment.
probably need the copyright head on this file.
Base automatically changed from
ui/VAULT-30635/handle-ember-cli-deprecations
to
main
September 17, 2024 19:59
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes this deprecation for ember engine router in every engine except replication (there are some other issues going on there that will have to be handled separately).
There are a lot of changes here because we have multiple engines, but the changes all fall into a few categories:
replace
routerengine dependencies with aliasedapp-routerinject
app-routerservice within engines instead ofrouterupdate
transition-towithin engines to use a helper which references theapp-routerservice insteadupdate
LinkedBlock(which is a core component used across engines and the main app) to useapp-routerservice if available, otherwise fall back to using the regularrouterserviceent tests pass