Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go on main to 1.23 #28273

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

upgrade go on main to 1.23 #28273

wants to merge 34 commits into from

Conversation

akshya96
Copy link
Contributor

@akshya96 akshya96 commented Sep 4, 2024

Description

What does this PR do?
Jira: https://hashicorp.atlassian.net/browse/VAULT-30420
Previous failure test: https://github.com/hashicorp/vault-enterprise/pull/6536

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Sep 4, 2024

CI Results: failed ❌
Failures:

Test Type Package Test Logs
race plugins/database/mssql TestUpdateUser_password view test results
standard plugins/database/mssql TestDeleteUserContainedDB view test results
standard plugins/database/mssql TestNewUser view test results

vault/ha.go Fixed Show fixed Hide fixed
vault/ha.go Fixed Show fixed Hide fixed
vault/ha.go Fixed Show fixed Hide fixed
vault/ha.go Fixed Show fixed Hide fixed
@akshya96 akshya96 requested review from a team as code owners September 6, 2024 20:25
@akshya96 akshya96 requested a review from a team as a code owner September 13, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant