Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing delegated_auth_accessors config field to /sys/mounts/<path> response #26876

Merged
merged 5 commits into from
May 8, 2024
Merged

Add missing delegated_auth_accessors config field to /sys/mounts/<path> response #26876

merged 5 commits into from
May 8, 2024

Conversation

stevendpclark
Copy link
Contributor

  • The field hadn't been properly populated in the JSON struct being returned through the API response, but had been properly set in the stored structs in the backend.
  • Add missing update to the command tune docs for the -delegated-auth-accessors option that existed
  • Add -delegated-auth-accessors to the secret enable vault command along with a docs update

@stevendpclark
Add missing delegated_auth_accessors config field to /sys/mounts/<pat…
b4bddb5 
…h> response

 - The field hadn't been properly populated in the JSON struct being returned
   through the API response, but had been properly set in the stored structs
   in the backend.
 - Add missing update to the command tune docs for the -delegated-auth-accessors
   option that existed
 - Add -delegated-auth-accessors to the secret enable vault command along with
   a docs update
@stevendpclark stevendpclark added this to the 1.16.3 milestone May 8, 2024
@stevendpclark stevendpclark requested a review from a team May 8, 2024 14:01
@stevendpclark stevendpclark self-assigned this May 8, 2024
@stevendpclark stevendpclark requested a review from a team as a code owner May 8, 2024 14:01
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

victorr
victorr approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Left a question, but it does not necessarily warrant changes.

command/secrets_enable.go Show resolved Hide resolved
schavis
schavis requested changes May 8, 2024
View reviewed changes
website/content/docs/commands/secrets/enable.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/secrets/tune.mdx Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan mentioned this pull request May 8, 2024
Merged
2 tasks
stevendpclark and others added 2 commits May 8, 2024 15:37
@stevendpclark @schavis
Apply suggestions from code review
4dedf2b 
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@stevendpclark
Drop plural on doc update
c9dd7e3
@stevendpclark stevendpclark enabled auto-merge (squash) May 8, 2024 19:52
@stevendpclark stevendpclark merged commit 259cfbf into main May 8, 2024
84 checks passed
@stevendpclark stevendpclark deleted the stevendpclark/vault-26906-return-delegated-auth branch May 8, 2024 19:58
Merged
@stevendpclark stevendpclark mentioned this pull request May 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schavis schavis schavis approved these changes

@victorr victorr victorr approved these changes

Assignees

@stevendpclark stevendpclark

Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.3
Development

Successfully merging this pull request may close these issues.
3 participants
@stevendpclark @victorr @schavis