Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual backport: Use a less strict URL validation for PKI issuing and crl distribution urls (#26477) #26514

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

sgmiller
Copy link
Collaborator

  • Use a less strict URL validation for PKI issuing and crl distribution urls

  • comma handling

  • limit to ldap

  • remove comma hack

  • changelog

  • Add unit test validating ldap CRL urls


… urls (#26477)

* Use a less strict URL validation for PKI issuing and crl distribution urls

* comma handling

* limit to ldap

* remove comma hack

* changelog

* Add unit test validating ldap CRL urls

---------

Co-authored-by: Steve Clark <steven.clark@hashicorp.com>
@sgmiller sgmiller requested a review from a team as a code owner April 18, 2024 17:49
@sgmiller sgmiller added this to the 1.15.8 milestone Apr 18, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 18, 2024
@sgmiller sgmiller changed the title Use a less strict URL validation for PKI issuing and crl distribution urls (#26477) Manual backport: Use a less strict URL validation for PKI issuing and crl distribution urls (#26477) Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

CI Results:
All required Go tests succeeded but failures were detected ⚠️
Failures:

Test Type Package Test Logs
race command TestAgent_RequireRequestHeader view test results

Copy link

github-actions bot commented Apr 18, 2024

Build Results:
All builds succeeded! ✅

@sgmiller sgmiller enabled auto-merge (squash) April 18, 2024 17:55
@sgmiller sgmiller merged commit 203110e into release/1.15.x Apr 18, 2024
74 of 76 checks passed
@sgmiller sgmiller deleted the sgm/backport-26477-1.15.x branch April 18, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants