Documentation for Self Healing Auto Auth Proxy and Agent #26324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
marcboudreau
reviewed
Apr 9, 2024
VioletHynes
reviewed
Apr 9, 2024
Comment on lines
25
to
26
| allowed. If renewal fails, the token has been revoked, or the token has exceeded the maximum number of uses, | ||
| it will attempt to reauthenticate. |
There was a problem hiding this comment.
Suggested change
| allowed. If renewal fails, the token has been revoked, or the token has exceeded the maximum number of uses, | |
| it will attempt to reauthenticate. | |
| allowed. If renewal fails, the token has been revoked, the token has exceeded | |
| the maximum number of uses, or is invalid for any other reason, it will attempt to reauthenticate. |
There was a problem hiding this comment.
The 'any other reason' was the initial onus for this request, so I thought I'd call it out explicitly!
There was a problem hiding this comment.
I just want to make sure that they don't confuse "invalid for any other reason" to be invalid because of invalid policy access.
There was a problem hiding this comment.
Hmm, you're right: what about "invalid for any reason other than access control"?
VioletHynes
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for how Auto Auth will self-heal for Agent and Proxy.
RFC: https://hermes.hashicorp.services/document/1yTtWJEvyoYLPkYRQ3lxs6dHmqAVyC177BMEBEXuu8fE?draft=false