Adding migrate parameter for the unseal operation #25550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dtrts
changed the title
dtrts
force-pushed
the
unseal-migrate-parameter
branch
from
e626a91 to
b170c8e
Compare
dtrts
force-pushed
the
unseal-migrate-parameter
branch
from
b170c8e to
0738901
Compare
sgmiller
requested changes
Feb 29, 2024
|
@sgmiller - Done. I copied the doc line from website/content/api-docs/system/unseal.mdx, i assume I don't have to make a similar change there? |
|
Ah, I see. Yeah, that shouldn't have it either, but not your fault. I'll take that one on. |
sgmiller
approved these changes
Mar 1, 2024
averche
approved these changes
Mar 28, 2024
|
@dtrts thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the openapi generator to include all the body parameters
https://developer.hashicorp.com/vault/api-docs/system/unseal
Follows on from finding this parameter missing in the hashicorp/vault-client-go repository
hashicorp/vault-client-go#253